Skip to content

8328864: NullPointerException in sun.security.jca.ProviderList.getService()#3442

Closed
satyenme wants to merge 2 commits intoopenjdk:masterfrom
satyenme:8328864
Closed

8328864: NullPointerException in sun.security.jca.ProviderList.getService()#3442
satyenme wants to merge 2 commits intoopenjdk:masterfrom
satyenme:8328864

Conversation

@satyenme
Copy link
Copy Markdown

@satyenme satyenme commented Apr 4, 2025 •
edited by openjdk Bot
Loading

Backporting JDK-8328864: NullPointerException in sun.security.jca.ProviderList.getService(). Updated getService to check whether getProvider returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328864 needs maintainer approval

Issue

  • JDK-8328864: NullPointerException in sun.security.jca.ProviderList.getService() (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3442/head:pull/3442
$ git checkout pull/3442

Update a local copy of the PR:
$ git checkout pull/3442
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3442

View PR using the GUI difftool:
$ git pr show -t 3442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3442.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 4, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport cd3a607576bede17f48c3d5ebde2bf05f3b615ba 8328864: NullPointerException in sun.security.jca.ProviderList.getService() Apr 4, 2025
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 4, 2025
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 4, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 4, 2025
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 4, 2025 •
edited
Loading

Webrevs

@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 4, 2025

/approval request for backport. Updated getService to check whether getProvider returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test.

Risk: Low. Tip change was merged in May 2024 and adds conditional statement to catch exception case, otherwise preserving functionality. Further, new test explicitly confirms altered functionality.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 4, 2025

@satyenme
8328864: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Apr 4, 2025
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 2, 2025

@satyenme This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@satyenme satyenme closed this May 23, 2025
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Jun 16, 2025

Hi @satyenme
Do you still want to bring this to 17? If so, please merge head for new testing and reopen this change.

@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Jun 18, 2025

Removing the lagel in the meantime.

@satyenme
Copy link
Copy Markdown
Author

satyenme commented Dec 8, 2025

/open

@openjdk openjdk Bot reopened this Dec 8, 2025
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Dec 8, 2025

@satyenme This pull request is now open

@openjdk openjdk Bot removed the approval Requires approval; will be removed when approval is received label Dec 8, 2025
@satyenme
Copy link
Copy Markdown
Author

satyenme commented Dec 8, 2025

/approval request for backport. Updated getService to check whether getProvider returns null when checking for preferred providers, continuing the loop if so. Added NullPreferredList test.

Risk: Low. Tip change was merged in May 2024 and adds conditional statement to catch exception case, otherwise preserving functionality. Further, new test explicitly confirms altered functionality.

Testing:

  • GHA Sanity Checks
  • Modified test locally

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Dec 8, 2025

@satyenme
8328864: The approval request has been updated successfully.

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 8, 2025
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Dec 9, 2025

Hi @satyenme
Please add to your fix request comment why we need this in 17.

@satyenme
Copy link
Copy Markdown
Author

satyenme commented Dec 15, 2025

Reflecting on it, at this point I don't see a pressing need to backport this back to 17 - I'll close this one out.

@satyenme satyenme closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@satyenme @GoeLin